animovscw commented on code in PR #12982:
URL: https://github.com/apache/ignite/pull/12982#discussion_r3207320972
##########
modules/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/JavaVersionCommand.java:
##########
@@ -56,13 +55,16 @@ int majorVersion(String javaHome) throws IOException,
InterruptedException {
/**
* Reads whole stream content and returns it as a string. UTF-8 is used to
convert from bytes to string.
*
- * @param inputStream Stream to read.
+ * @param inputStream Stream to read.
* @return Stream content as a string.
* @throws IOException If something goes wrong.
*/
private String readStream(InputStream inputStream) throws IOException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
- IOUtils.copy(inputStream, baos);
+ byte[] buf = new byte[4096];
Review Comment:
The decision of this change is not about removing `commons-io`.
`JavaVersionCommand.java` runs inside a forked JVM. The forked process
classpath does not include test-scoped dependencies, so commons-io is not
available here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
