alex-plekhanov commented on code in PR #13162:
URL: https://github.com/apache/ignite/pull/13162#discussion_r3279745790
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/TxWithExceptionalInterceptorTest.java:
##########
@@ -363,8 +366,19 @@ public void testTxWithExceptionInterceptor() throws
Exception {
continue;
}
+ Object sqlVal;
+
// obtain sql results first, kv api can eventually recover
results, thus for more clear test - let`s check sql first
- Object sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME,
primaryKey, false);
+ try {
+ sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey,
false);
+ }
+ catch (IgniteSQLException ex) {
+ assertTrue(X.hasCause(ex, ClusterTopologyException.class));
Review Comment:
1. Block under condition `txCoord == TxCoordNodeRole.PRIMARY` uses
`getSqlResultByKey` method too, but not covered by the same check. Why?
2. There is a line in this method:
```
Integer primaryKeyCommon = primaryKeyCoordAware(PROC_CACHE_NAME);
```
Here PROC_CACHE_NAME is used, but not COMMON_CACHE_NAME. Is it intentional?
3. Several code style violations in this method (comment is not started with
uppercase, and not ended with the point. Let's fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
