sergey-chugunov-1985 commented on code in PR #13146:
URL: https://github.com/apache/ignite/pull/13146#discussion_r3286800248
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
+|STATE | string | Current transaction state
+|XID | UUID | Unique transaction identifier
+|LABEL | string | Transaction label
+|START_TIME | long | Start time of the transaction on this node
+|ISOLATION | string | Transaction isolation level
+|CONCURRENCY | string | Transaction concurrency mode
+|KEYS_COUNT | int | Number of cache keys participating in the transaction
+|CACHE_IDS | string | Comma-separated IDs of caches participating in the
transaction
+|COLOCATED | boolean | `True` if the transaction is DHT colocated
+|DHT | boolean | `True` if the transaction is DHT
+|DURATION | long | Transaction duration in milliseconds
+|IMPLICIT | boolean | `True` if the transaction was started implicitly
+|IMPLICIT_SINGLE | boolean | `True` if the transaction is implicit with only
one key
+|INTERNAL | boolean | `True` if the transaction has at least one internal entry
+|LOCAL | boolean | `True` if the transaction is local, `false` if it is remote
+|LOCAL_NODE_ID | UUID | Local node ID
+|NEAR | boolean | `True` if the transaction is near
+|ONE_PHASE_COMMIT | boolean | `True` if the transaction is a one-phase-commit
transaction
+|OTHER_NODE_ID | UUID | ID of an additional node involved in the transaction
+|SUBJECT_ID | UUID | ID of the subject that initiated the transaction
+|SYSTEM | boolean | `True` if the transaction was started for a system cache
+|THREAD_ID | long | ID of the thread in which the transaction started
Review Comment:
```suggestion
|THREAD_ID | long | ID of the thread started the transaction
```
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
+|STATE | string | Current transaction state
+|XID | UUID | Unique transaction identifier
+|LABEL | string | Transaction label
+|START_TIME | long | Start time of the transaction on this node
+|ISOLATION | string | Transaction isolation level
+|CONCURRENCY | string | Transaction concurrency mode
+|KEYS_COUNT | int | Number of cache keys participating in the transaction
+|CACHE_IDS | string | Comma-separated IDs of caches participating in the
transaction
+|COLOCATED | boolean | `True` if the transaction is DHT colocated
+|DHT | boolean | `True` if the transaction is DHT
Review Comment:
We need to clarify what DHT means in this context.
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
+|STATE | string | Current transaction state
+|XID | UUID | Unique transaction identifier
+|LABEL | string | Transaction label
+|START_TIME | long | Start time of the transaction on this node
+|ISOLATION | string | Transaction isolation level
+|CONCURRENCY | string | Transaction concurrency mode
+|KEYS_COUNT | int | Number of cache keys participating in the transaction
+|CACHE_IDS | string | Comma-separated IDs of caches participating in the
transaction
+|COLOCATED | boolean | `True` if the transaction is DHT colocated
+|DHT | boolean | `True` if the transaction is DHT
+|DURATION | long | Transaction duration in milliseconds
+|IMPLICIT | boolean | `True` if the transaction was started implicitly
+|IMPLICIT_SINGLE | boolean | `True` if the transaction is implicit with only
one key
+|INTERNAL | boolean | `True` if the transaction has at least one internal entry
+|LOCAL | boolean | `True` if the transaction is local, `false` if it is remote
+|LOCAL_NODE_ID | UUID | Local node ID
+|NEAR | boolean | `True` if the transaction is near
+|ONE_PHASE_COMMIT | boolean | `True` if the transaction is a one-phase-commit
transaction
+|OTHER_NODE_ID | UUID | ID of an additional node involved in the transaction
+|SUBJECT_ID | UUID | ID of the subject that initiated the transaction
+|SYSTEM | boolean | `True` if the transaction was started for a system cache
+|THREAD_ID | long | ID of the thread in which the transaction started
+|TIMEOUT | long | Transaction timeout in milliseconds
+|TOP_VER | string | Topology version
Review Comment:
Is it current topology version or a top ver the transaction started at?
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
Review Comment:
We need to clarify what a "directly started the transaction" means. I guess
it is a node that initiated the transaction but not necessarily the node that
has any keys the transaction touches.
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
+|STATE | string | Current transaction state
+|XID | UUID | Unique transaction identifier
+|LABEL | string | Transaction label
+|START_TIME | long | Start time of the transaction on this node
+|ISOLATION | string | Transaction isolation level
+|CONCURRENCY | string | Transaction concurrency mode
+|KEYS_COUNT | int | Number of cache keys participating in the transaction
+|CACHE_IDS | string | Comma-separated IDs of caches participating in the
transaction
+|COLOCATED | boolean | `True` if the transaction is DHT colocated
+|DHT | boolean | `True` if the transaction is DHT
+|DURATION | long | Transaction duration in milliseconds
+|IMPLICIT | boolean | `True` if the transaction was started implicitly
+|IMPLICIT_SINGLE | boolean | `True` if the transaction is implicit with only
one key
+|INTERNAL | boolean | `True` if the transaction has at least one internal entry
Review Comment:
What an internal entry is?
##########
docs/_docs/monitoring-metrics/system-views.adoc:
##########
@@ -270,31 +270,31 @@ This view exposes information about currently running
transactions.
[{table_opts}]
|===
|NAME | TYPE | DESCRIPTION
-|ORIGINATING_NODE_ID | UUID |
-|STATE | string |
-|XID | UUID |
-|LABEL | string |
-|START_TIME | long |
-|ISOLATION | string |
-|CONCURRENCY | string |
-|KEYS_COUNT | int |
-|CACHE_IDS | string |
-|COLOCATED | boolean |
-|DHT | boolean |
-|DURATION | long |
-|IMPLICIT | boolean |
-|IMPLICIT_SINGLE | boolean |
-|INTERNAL | boolean |
-|LOCAL | boolean |
-|LOCAL_NODE_ID | UUID |
-|NEAR | boolean |
-|ONE_PHASE_COMMIT | boolean |
-|OTHER_NODE_ID | UUID |
-|SUBJECT_ID | UUID |
-|SYSTEM | boolean |
-|THREAD_ID | long |
-|TIMEOUT | long |
-|TOP_VER | string |
+|ORIGINATING_NODE_ID | UUID | ID of the node that directly started the
transaction
+|STATE | string | Current transaction state
+|XID | UUID | Unique transaction identifier
+|LABEL | string | Transaction label
+|START_TIME | long | Start time of the transaction on this node
+|ISOLATION | string | Transaction isolation level
+|CONCURRENCY | string | Transaction concurrency mode
+|KEYS_COUNT | int | Number of cache keys participating in the transaction
+|CACHE_IDS | string | Comma-separated IDs of caches participating in the
transaction
+|COLOCATED | boolean | `True` if the transaction is DHT colocated
+|DHT | boolean | `True` if the transaction is DHT
+|DURATION | long | Transaction duration in milliseconds
+|IMPLICIT | boolean | `True` if the transaction was started implicitly
+|IMPLICIT_SINGLE | boolean | `True` if the transaction is implicit with only
one key
+|INTERNAL | boolean | `True` if the transaction has at least one internal entry
+|LOCAL | boolean | `True` if the transaction is local, `false` if it is remote
Review Comment:
"Local" vs "remote" has to be clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
