alex-plekhanov commented on code in PR #13219:
URL: https://github.com/apache/ignite/pull/13219#discussion_r3414419735
##########
modules/core/src/main/java/org/apache/ignite/internal/MarshallerContextImpl.java:
##########
@@ -541,21 +541,38 @@ else if (clientNode) {
/**
* @param platformId Platform id.
* @param typeId Type id.
+ * @param ensureAccepted Ensure that mapping is accepted.
*/
- public String resolveMissedMapping(byte platformId, int typeId) {
+ private @Nullable String resolveClassName(byte platformId, int typeId,
boolean ensureAccepted) {
ConcurrentMap<Integer, MappedName> cache = getCacheFor(platformId);
MappedName mappedName = cache.get(typeId);
if (mappedName != null) {
- assert mappedName.accepted() : mappedName;
+ assert !ensureAccepted || mappedName.accepted() : mappedName;
Review Comment:
Accepted flag means that mapping is accpeted by cluster. Assertion here is
to keep invariant implemented in method resolveMissedMapping, (looks like this
method should be called only for accepted mapping), but for new check I don't
think it's always true, so, just in case, removed this assert)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
