anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3436206429
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TxLocksRequest.java:
##########
@@ -89,33 +90,20 @@ public Collection<IgniteTxKey> txKeys() {
}
/** {@inheritDoc} */
- @Override public void prepareMarshal(GridCacheSharedContext<?, ?> ctx)
throws IgniteCheckedException {
- super.prepareMarshal(ctx);
-
+ @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
txKeysArr = new IgniteTxKey[txKeys.size()];
int i = 0;
- for (IgniteTxKey key : txKeys) {
- key.prepareMarshal(ctx.cacheContext(key.cacheId()));
-
+ for (IgniteTxKey key : txKeys)
txKeysArr[i++] = key;
- }
}
/** {@inheritDoc} */
- @Override public void finishUnmarshal(GridCacheSharedContext<?, ?> ctx,
ClassLoader ldr) throws IgniteCheckedException {
- super.finishUnmarshal(ctx, ldr);
-
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader
clsLdr) throws IgniteCheckedException {
txKeys = U.newHashSet(txKeysArr.length);
- for (IgniteTxKey key : txKeysArr) {
- key.finishUnmarshal(ctx.cacheContext(key.cacheId()), ldr);
-
+ for (IgniteTxKey key : txKeysArr)
txKeys.add(key);
- }
-
- txKeysArr = null;
}
Review Comment:
This is a shot-living message, no need for special cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
