zstan commented on code in PR #13255:
URL: https://github.com/apache/ignite/pull/13255#discussion_r3450345308
##########
modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/future/JmhFutureAdapterBenchmark.java:
##########
@@ -140,6 +143,8 @@ private static void run(int threads) throws Exception {
.measurementIterations(30)
.benchmarks(JmhFutureAdapterBenchmark.class.getSimpleName())
.jvmArguments("-Xms4g", "-Xmx4g")
+ .benchmarkModes(Throughput)
+ .outputTimeUnit(SECONDS)
Review Comment:
as i can see: benchmarkModes(Throughput) and outputTimeUnit(SECONDS) is a
default values, why do we need additionally set them, did i miss smth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
