petrov-mg commented on code in PR #13243: URL: https://github.com/apache/ignite/pull/13243#discussion_r3452339180
########## modules/core/src/main/java/org/apache/ignite/internal/DistributedOperationContextMessage.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.util.List; +import org.apache.ignite.internal.thread.context.OperationContext; +import org.apache.ignite.plugin.extensions.communication.Message; + +/** Transport for {@link OperationContext} distibuted attributes. */ +public class DistributedOperationContextAttributesMessage implements Message { + /** Values of operation context attributes. */ + @Order(0) + public List<Message> vals; Review Comment: > re-copy of it with actual size. This doesn't seem to be a problem, since the List will be created on the stack for the duration of the collectDistributedAttributes method. `DistributedOperationAttributesMessage` can be attached to ALL communication and discovery messages. But serializing a List currently requires one extra byte for the collection type. So i think it worth making `DistributedOperationAttributesMessage` as compact as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
