petrov-mg commented on code in PR #13243:
URL: https://github.com/apache/ignite/pull/13243#discussion_r3457315177
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ClientImpl.java:
##########
@@ -1757,276 +1761,290 @@ private MessageWorker(IgniteLogger log) {
blockingSectionEnd();
}
- if (msg instanceof JoinTimeout) {
- int joinCnt0 = ((JoinTimeout)msg).joinCnt;
-
- if (joinCnt == joinCnt0) {
- if (state == STARTING) {
- joinError(new IgniteSpiException("Join process
timed out, did not receive response for " +
- "join request (consider increasing
'joinTimeout' configuration property) " +
- "[joinTimeout=" + spi.joinTimeout + ",
sock=" + currSock + ']'));
-
+ if (msg instanceof TcpDiscoveryAbstractMessage msg0 &&
msg0.opCtxMsg != null) {
Review Comment:
Obviously, that's not what I meant. Let's wrap the code related to
processing of the message from the moment it is polled from the queue, but not
move anything to other new methods.
In the current state of the code, moving the message handling logic into a
separate method seems awkward. It's better to refactor this later in a separate
ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
