chesnokoff commented on code in PR #13263:
URL: https://github.com/apache/ignite/pull/13263#discussion_r3472683548
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheAffinitySharedManager.java:
##########
@@ -2079,6 +2090,40 @@ public IgniteInternalFuture<?> initCoordinatorCaches(
return null;
}
+ /** */
+ private boolean skipNotStartedDynamicGroupOnFirstLocalJoin(
+ GridDhtPartitionsExchangeFuture fut,
+ CacheGroupDescriptor desc,
+ @Nullable CacheGroupContext grp,
+ boolean newAff
+ ) {
+ if (grp != null)
+ return false;
+
+ if (newAff)
+ return false;
+
+ if (!firstLocalJoinExchange(fut))
+ return false;
+
+ AffinityTopologyVersion grpStartTopVer = desc.startTopologyVersion();
+
+ if (grpStartTopVer == null)
+ return false;
+
+ return grpStartTopVer.after(fut.initialVersion());
+ }
Review Comment:
Can we make smth like
```java
/** */
private boolean skipNotStartedDynamicGroup(
GridDhtPartitionsExchangeFuture fut,
CacheGroupDescriptor desc,
@Nullable CacheGroupContext grp,
boolean newAff
) {
if (grp != null || newAff)
return false;
AffinityTopologyVersion grpStartTopVer = desc.startTopologyVersion();
return grpStartTopVer != null &&
grpStartTopVer.after(fut.initialVersion());
}
```
To make this check based on the cache group start version instead of the
first join?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
