chesnokoff commented on code in PR #13265:
URL: https://github.com/apache/ignite/pull/13265#discussion_r3476480928


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryMarshallerTest.java:
##########
@@ -83,6 +83,8 @@ private void check(String node1Name, String node2Name) throws 
Exception {
 
         final Ignite node2 = "client".equals(node2Name) ? 
startClientGrid(node2Name) : startGrid(node2Name);
 
+        awaitPartitionMapExchange();

Review Comment:
   I'd prefer not to add this comment. It mostly repeats the method name: 
`awaitPartitionMapExchange()` already says that we wait for PME
   
   Also, "rebalance" is a bit too narrow here. The main point is that the 
initial scan should not start while the topology and  partition map is still 
changing after `server2` joins



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to