anton-vinogradov opened a new pull request, #13280: URL: https://github.com/apache/ignite/pull/13280
## What Collapse the two near-identical detection loops in the `Rolling Upgrade check` step (added/deleted files vs modified files) into a single loop driven by `git diff --name-status`. The revision to inspect is selected per file status: `A` → head, `D`/`M` → base. ## Why The two loops differed only in the diff filter and the grepped revision, duplicating the loop body. The single loop roughly halves the cyclomatic/cognitive complexity (≈7 → ≈4) and removes the duplication. ## Behaviour Verified equivalent to the previous logic on add / modify / delete / rename scenarios. One intentional difference: the content-based grep no longer flags add/delete of the annotation's own definition file `org/apache/ignite/internal/Order*.java`. The previous diff-based grep matched the file *path* in diff headers (the regex dots match slashes) — a false positive, since that file is the `@Order` definition, not a protected class. ## Notes - Independent of [#13279](https://github.com/apache/ignite/pull/13279) (different hunk of the same file); no conflict expected. Jira: https://issues.apache.org/jira/browse/IGNITE-28822 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
