EgorBaranovEnjoysTyping commented on code in PR #13262:
URL: https://github.com/apache/ignite/pull/13262#discussion_r3482083394


##########
modules/commons/src/main/java/org/apache/ignite/internal/util/tostring/SBLimitedLength.java:
##########
@@ -270,6 +264,124 @@ private GridStringBuilder onWrite(int lenBeforeWrite) {
         return onWrite(curLen);
     }
 
+    /** {@inheritDoc} */
+    @Override public GridStringBuilder i(int offset, String str) {

Review Comment:
   I dropped recoverObject.
   I don't want to artificially modify the tests by removing valid cases just 
to satisfy the 'Fix NPE' requirement. I'd rather view this task as 'The 
handleRecursion method is not working correctly'."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to