anton-vinogradov commented on code in PR #13257:
URL: https://github.com/apache/ignite/pull/13257#discussion_r3499398258
##########
.github/workflows/commit-check.yml:
##########
@@ -99,6 +99,10 @@ jobs:
run: |
./mvnw test-compile
-Pall-java,licenses,lgpl,checkstyle,examples,check-licenses -B -V -T 1C
+ - name: Documentation code snippets compilation check
+ run: |
+ ./mvnw -Pdocs -pl :code-snippets -am compile -B -V
Review Comment:
Two things worth reconsidering here:
1. **Redundant full recompile.** `-am compile` rebuilds the entire upstream
dependency chain (`ignite-core` plus all transitive modules) from scratch,
because the profile set here (`-Pdocs`) differs from the previous `test-compile
-Pall-java,…` step, so none of the just-compiled classes are reused. That is a
second full reactor build of those modules.
2. **Placement vs. class reuse.** This step is inserted between the
codestyle step and the "Run abandoned tests checks" step, and it overwrites the
upstream modules' `target/classes` under a *different* profile than the
abandoned-tests step expects (note the existing comment on that step about
reusing classes / avoiding a full reactor recompile).
Suggestion: move this step to the very end of the job (after the javadoc
check) so it doesn't perturb the reuse between the surrounding steps, or fold
the `docs` profile + module into the existing `test-compile` reactor invocation
to avoid the second recompile entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
