wernerdv commented on code in PR #13184:
URL: https://github.com/apache/ignite/pull/13184#discussion_r3504030829
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java:
##########
@@ -1269,7 +1269,8 @@ LinkedHashSet<InetSocketAddress>
getEffectiveNodeAddresses(TcpDiscoveryNode node
// Do not give own loopback to avoid requesting current node.
if (!node.equals(locNode))
- addrs.removeIf(addr -> addr.getAddress().isLoopbackAddress() &&
locNode.socketAddresses().contains(addr));
+ addrs.removeIf(addr -> addr.getAddress() == null ||
+ (addr.getAddress().isLoopbackAddress() &&
locNode.socketAddresses().contains(addr)));
Review Comment:
Without this change, the test will fail:
```
[c1099d16-e7d7-49f4-925c-53329286c444] java.lang.NullPointerException:
Cannot invoke "java.net.InetAddress.isLoopbackAddress()" because the return
value of "java.net.InetSocketAddress.getAddress()" is null
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.lambda$getEffectiveNodeAddresses$0(TcpDiscoverySpi.java:1272)
[c1099d16-e7d7-49f4-925c-53329286c444] at
java.base/java.util.ArrayList.removeIf(Unknown Source)
[c1099d16-e7d7-49f4-925c-53329286c444] at
java.base/java.util.ArrayList.removeIf(Unknown Source)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.getEffectiveNodeAddresses(TcpDiscoverySpi.java:1272)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.getEffectiveNodeAddresses(TcpDiscoverySpi.java:1253)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.ServerImpl$SocketReader.pingJoiningNode(ServerImpl.java:7665)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.ServerImpl$SocketReader.processJoinRequestMessage(ServerImpl.java:7602)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.discovery.tcp.ServerImpl$SocketReader.body(ServerImpl.java:7076)
[c1099d16-e7d7-49f4-925c-53329286c444] at
org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:58)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
