sergey-chugunov-1985 commented on code in PR #13304:
URL: https://github.com/apache/ignite/pull/13304#discussion_r3529489518


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/RollingUpgradeProcessor.java:
##########
@@ -301,71 +325,136 @@ else if 
(!joiningNode.version().equals(localProductVersion())) {
     }
 
     /** */
-    private IgniteProductVersion localProductVersion() {
-        return featureMgr.localVersionFeatures().version();
-    }
+    private IgniteComponentUpgradeState 
detectComponentUpgradeState(Map<ClusterNode, IgniteFeatures> clusterFeatures, 
String cmpName) {
+        SortedSet<IgniteProductVersion> clusterCmpVersions = 
distinctClusterComponentVersions(clusterFeatures, cmpName);
 
-    /** */
-    private IgniteProductVersion clusterLogicalVersion() {
-        return featureMgr.activeFeatures().version();
+        assert !clusterCmpVersions.isEmpty() && clusterCmpVersions.size() <= 2;

Review Comment:
   Please add an error message to this assertion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to