vldpyatkov commented on code in PR #13298:
URL: https://github.com/apache/ignite/pull/13298#discussion_r3530002414
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java:
##########
@@ -3139,8 +3137,18 @@ private TxRecoveryInitRunnable(ClusterNode node) {
else if (tx.storeWriteThrough() &&
!tx.masterNodeIds().contains(cctx.localNodeId())
&& tx.nodeId().equals(evtNodeId) && tx.state() ==
PREPARED) {
// Delay a commit, on backup. It will be raised
further after near or coord. node will confirm it.
- // In different from {@code FULL_SYNC} modes,
appropriate recovery message can never be raized.
- if (deriveSyncMode(cctx, tx.txState().cacheIds()) !=
FULL_SYNC)
+ // In modes different from FULL_SYNC, appropriate
recovery message can never be raized.
+ // Approach with {@code
IgniteTxImplicitSingleStateImpl.syncMode} can`t be used here because
+ // {@code IgniteTxRemoteStateAdapter#cacheIds} can be
empty.
+ boolean fullSyncedOp = false;
+ for (IgniteTxEntry ent : tx.writeEntries()) {
+ if (cctx.cacheContext(ent.cacheId()).syncCommit())
{
Review Comment:
Are you sure that you can commit a transaction beyond a near node or
coordinator node?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
