anton-vinogradov commented on PR #13329: URL: https://github.com/apache/ignite/pull/13329#issuecomment-4895868777
Prepared ready-to-merge fixes for everything above: wernerdv/ignite#3 (targets this PR's branch, so merging it brings the fixes straight here). Beyond the six review items, self-reviewing the fixes surfaced two more issues that are also addressed there: * an exception thrown from *inside* the payload deserialization (not just a silent partial read) left the reused `tmpReader` with half-read state — the drop is now done in a `finally`; * a lying `dataSize` could still inflate the chunk-list capacity allocation in `readFrom()` (~1.7 MB of `Object[]` for a ~15-byte wire message) — the pre-size is now clamped. Verification: `CompressedMessageTest` 7/7 (5 new cases), `DirectMarshallingMessagesTest` green, `-Pcheckstyle` clean, benchmarks module compiles. Known accepted limitations are listed in the fix PR description. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
