zstan commented on code in PR #13267: URL: https://github.com/apache/ignite/pull/13267#discussion_r3537262240
########## modules/jta/src/test/java/org/apache/ignite/internal/processors/cache/jta/TransactionManagerWrapper.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.jta; + +import java.lang.reflect.Field; +import java.util.ArrayList; +import java.util.Enumeration; +import java.util.Hashtable; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import jakarta.transaction.HeuristicMixedException; +import jakarta.transaction.HeuristicRollbackException; +import jakarta.transaction.InvalidTransactionException; +import jakarta.transaction.NotSupportedException; +import jakarta.transaction.RollbackException; +import jakarta.transaction.SystemException; +import jakarta.transaction.Transaction; +import jakarta.transaction.TransactionManager; +import javax.transaction.xa.XAResource; +import javax.transaction.xa.Xid; + +import com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple; +import com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionManagerImple; +import com.arjuna.ats.internal.jta.xa.TxInfo; + +/** + * Narayana TransactionManager wrapper that simulates JOTM-style suspend/resume. + * <p> + * Each wrapper instance has its own state (not shared between parallel tests). + */ +public class TransactionManagerWrapper implements TransactionManager { Review Comment: I missunderstand why do you need this wrapper under TransactionImple ? Plz explain ? ########## parent/pom.xml: ########## @@ -83,10 +83,10 @@ <javax.cache.bundle.version>1.0.0_1</javax.cache.bundle.version> <javax.cache.tck.version>1.1.1</javax.cache.tck.version> <javax.cache.version>1.0.0</javax.cache.version> - <jboss.rmi.version>1.0.6.Final</jboss.rmi.version> Review Comment: why we need to remove it ? i store it as is, apply all other changes and also not append : <narayana.version>7.3.4.Final</narayana.version> and tests seems ok, did i miss smth ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
