anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3545256497
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/processors/cache/CacheObject.java:
##########
@@ -120,13 +120,13 @@ public interface CacheObject {
* @param ldr Class loader.
* @throws IgniteCheckedException If failed.
*/
- public void finishUnmarshal(CacheObjectValueContext ctx, ClassLoader ldr)
throws IgniteCheckedException;
+ public void unmarshal(CacheObjectValueContext ctx, ClassLoader ldr) throws
IgniteCheckedException;
/**
* @param ctx Context.
* @throws IgniteCheckedException If failed.
*/
- public void prepareMarshal(CacheObjectValueContext ctx) throws
IgniteCheckedException;
+ public void marshal(CacheObjectValueContext ctx) throws
IgniteCheckedException;
Review Comment:
No, answered earlier :)
It's easy to ignore during review + this fixes design. Otherwise, we'll get
a situation where prepareMarshall calls finishUnmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
