chesnokoff commented on code in PR #336:
URL: https://github.com/apache/ignite-extensions/pull/336#discussion_r2940128359
##########
modules/performance-statistics-ext/report/css/dashboard.css:
##########
@@ -62,7 +62,7 @@ body {
}
.sidebar .nav-link.active {
- color: #007bff;
+ color: #0d6efd;
Review Comment:
Do we really need this change?
##########
modules/performance-statistics-ext/report/libs/bootstrap.bundle.min.js:
##########
@@ -0,0 +1,7 @@
+/*!
Review Comment:
This file is not the Bootstrap bundle. It is the normal Bootstrap file,
which needs Popper.
This PR removes `popper.min.js`, so the page-size dropdown does not work.
locally i could reproduce `TypeError: i.createPopper is not a function`
Please use the real bundle:
https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.3.8/js/bootstrap.bundle.min.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
