chesnokoff commented on code in PR #355: URL: https://github.com/apache/ignite-extensions/pull/355#discussion_r3570451162
########## modules/auto-activation-ext/src/test/resources/activate-by-consistent-ID/ignite-server-node1.xml: ########## @@ -0,0 +1,113 @@ +<beans xmlns="http://www.springframework.org/schema/beans" Review Comment: These XML test configs duplicate most of the Ignite configuration. Can we move the common storage/cache/discovery/connector settings to a shared parent bean or common XML file, and keep only node-specific values here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
