wernerdv commented on code in PR #360:
URL: https://github.com/apache/ignite-extensions/pull/360#discussion_r3585220138
##########
modules/hibernate-ext/hibernate/src/test/java/org/apache/ignite/cache/hibernate/HibernateL2CacheSelfTest.java:
##########
@@ -1764,13 +1767,21 @@ private void testRegionClear(AccessType accessType)
throws Exception {
* @param absentNames Absent entities' names.
*/
private void assertNaturalIdCache(SessionFactory sesFactory, Map<String,
Integer> nameToId, String... absentNames) {
- sesFactory.getStatistics().clear();
-
- CacheRegionStatistics stats =
sesFactory.getStatistics().getCacheRegionStatistics(NATURAL_ID_REGION);
+ // H6: Natural ID cache doesn't auto-invalidate on mutation across
SessionFactories,
Review Comment:
If we fully roll back the changes and proceed as suggested, flaky tests may
occur.
For example:
https://ci2.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_Hibernate/9210734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
