shishkovilja commented on code in PR #13344:
URL: https://github.com/apache/ignite/pull/13344#discussion_r3585229685
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceInfo.java:
##########
@@ -35,32 +41,45 @@
/**
* Service's information container.
*/
-public class ServiceInfo implements ServiceDescriptor {
+public class ServiceInfo implements ServiceDescriptor, MarshallableMessage {
/** */
private static final long serialVersionUID = 0L;
/** Context. */
private transient volatile GridKernalContext ctx;
/** Origin node ID. */
- private final UUID originNodeId;
+ @Order(0)
+ UUID originNodeId;
/** Service id. */
- private final IgniteUuid srvcId;
+ @Order(1)
+ IgniteUuid srvcId;
/** Service configuration. */
- private final LazyServiceConfiguration cfg;
+ private LazyServiceConfiguration cfg;
+
+ /** Serialized {@link #cfg}.*/
+ @Order(2)
+ transient byte[] cfgBytes;
Review Comment:
I suggest to add message companion for `LazyServiceConfiguration`:
1. It can be easily copypsated from `LazyServiceConfiguration` (with
exclusion of any excessive logic).
2. Serde test should be added. See `QueryEntityMessageSerializationTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
