anton-vinogradov commented on code in PR #13095: URL: https://github.com/apache/ignite/pull/13095#discussion_r3598905778
########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/MessageUnmarshalDedup.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import java.lang.ref.Reference; +import java.lang.ref.ReferenceQueue; +import java.lang.ref.WeakReference; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.IgniteSystemProperties; +import org.apache.ignite.internal.MarshallableMessage; +import org.apache.ignite.plugin.extensions.communication.Message; +import org.apache.ignite.plugin.extensions.communication.MessageMarshaller; + +/** + * Detects a {@link MarshallableMessage} instance being finish-unmarshalled more than once within the same pass + * (cache-aware or cache-free) — a class-loader or receive-path bug. The two passes over one message (e.g. the + * generic {@code GridIoManager} pass plus a subsystem's cache-aware pass) are legitimate and tracked separately. + * Gated by {@link #ENABLED}, so it runs only under tests and is folded away in production. + * + * @see MessageMarshaller + */ +public class MessageUnmarshalDedup { Review Comment: Done — with a detour worth reporting. First I built the literal mirror check (identity-keyed `MessageMarshalOnceCheck` asserted in `MessageMarshalling.marshal`, suite-wide): **275 firings**, every grid-starting test red — discovery ring forwarding re-marshals the *same* instance per hop by design (`TcpDiscoveryJoinRequestMessage` and its `TcpDiscoveryNode`s, each repeat a guarded no-op). So marshal-once is not a global per-instance invariant the way unmarshal-once is: a receive always yields a fresh instance, a send may legitimately reuse one. The invariant that *does* exist is per transmission unit: a `GridIoMessage` is marshalled exactly once before transmit. That's now enforced by construction instead of a weak-set detector: the `prepared` flag you suggested earlier is generalized to `marshalled`, a private `GridIoManager.marshal(ioMsg)` asserts not-yet-marshalled → marshals → marks at all four marshal points (prepare / send / openChannel / sendToMany), and `sendPrepare d` asserts marshalled. Any future re-marshal on a retry loop, double prepare, or transmit of an unmarshalled wrap trips the assert on every test run — no system property or detector machinery needed. ########## modules/core/src/main/java/org/apache/ignite/internal/managers/communication/MessageUnmarshalDedup.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.managers.communication; + +import java.lang.ref.Reference; +import java.lang.ref.ReferenceQueue; +import java.lang.ref.WeakReference; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.IgniteSystemProperties; +import org.apache.ignite.internal.MarshallableMessage; +import org.apache.ignite.plugin.extensions.communication.Message; +import org.apache.ignite.plugin.extensions.communication.MessageMarshaller; + +/** + * Detects a {@link MarshallableMessage} instance being finish-unmarshalled more than once within the same pass + * (cache-aware or cache-free) — a class-loader or receive-path bug. The two passes over one message (e.g. the + * generic {@code GridIoManager} pass plus a subsystem's cache-aware pass) are legitimate and tracked separately. + * Gated by {@link #ENABLED}, so it runs only under tests and is folded away in production. + * + * @see MessageMarshaller + */ +public class MessageUnmarshalDedup { Review Comment: Done — with a detour worth reporting. First I built the literal mirror check (identity-keyed `MessageMarshalOnceCheck` asserted in `MessageMarshalling.marshal`, suite-wide): **275 firings**, every grid-starting test red — discovery ring forwarding re-marshals the *same* instance per hop by design (`TcpDiscoveryJoinRequestMessage` and its `TcpDiscoveryNode`s, each repeat a guarded no-op). So marshal-once is not a global per-instance invariant the way unmarshal-once is: a receive always yields a fresh instance, a send may legitimately reuse one. The invariant that *does* exist is per transmission unit: a `GridIoMessage` is marshalled exactly once before transmit. That's now enforced by construction instead of a weak-set detector: the `prepared` flag you suggested earlier is generalized to `marshalled`, a private `GridIoManager.marshal(ioMsg)` asserts not-yet-marshalled → marshals → marks at all four marshal points (prepare / send / openChannel / sendToMany), and `sendPrepare d` asserts marshalled. Any future re-marshal on a retry loop, double prepare, or transmit of an unmarshalled wrap trips the assert on every test run — no system property or detector machinery needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
