alex-plekhanov commented on code in PR #13407:
URL: https://github.com/apache/ignite/pull/13407#discussion_r3675544945


##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SortAggregateIntegrationTest.java:
##########
@@ -155,6 +155,30 @@ public void testNullsReordering() {
             .check();
     }
 
+    /**
+     * Tests that sort aggregate node correctly handles the case when input 
data
+     * ends exactly when the requested number of rows is satisfied.
+     */
+    @Test
+    public void testRequestRowsAfterInputEnds() {

Review Comment:
   For `ALL` and `RANDOM` plan is not the same as for `NONE`, for this reason 
plan checkers (`matches` method) are disabled for `ALL` and `RANDOM`. But 
result still should be valid for these tx modes even with another plan, so I 
think test is also helpful for these modes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to