shishkovilja commented on code in PR #13386:
URL: https://github.com/apache/ignite/pull/13386#discussion_r3676173452
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheData.java:
##########
@@ -17,59 +17,69 @@
package org.apache.ignite.internal.processors.cache;
-import java.io.Serializable;
import java.util.UUID;
import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.Marshalled;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.processors.query.QuerySchema;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.plugin.extensions.communication.Message;
+import org.apache.ignite.plugin.extensions.communication.MessageFactory;
-/**
- * Cache information sent in discovery data to joining node.
- */
-public class CacheData implements Serializable {
+/** Cache information sent in discovery data to joining node. */
+public class CacheData implements Message {
/** */
- private static final long serialVersionUID = 0L;
+ @Marshalled("cacheCfgBytes")
+ CacheConfiguration cacheCfg;
- /** */
- private final CacheConfiguration cacheCfg;
+ /** Serialized {@link #cacheCfg}. */
+ @Order(0)
+ byte[] cacheCfgBytes;
/** */
- private final int cacheId;
+ @Order(1)
+ int grpId;
/** */
- private final int grpId;
+ @Order(2)
+ CacheType cacheType;
/** */
- private final CacheType cacheType;
+ @Order(3)
+ IgniteUuid deploymentId;
/** */
- private final IgniteUuid deploymentId;
+ @Marshalled("schemaBytes")
+ QuerySchema schema;
Review Comment:
As I see, `QuerySchema` is just a collection of `QueryEntity`. Can we use
`Collection<QueryEntityMessage>` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
