wernerdv commented on code in PR #13409:
URL: https://github.com/apache/ignite/pull/13409#discussion_r3690146991
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageHistoryItem.java:
##########
@@ -62,6 +71,16 @@ public DistributedMetaStorageHistoryItem(String[] keys,
byte[][] valBytesArr) {
this.valBytesArr = valBytesArr;
}
+ /** @return Array of {@link DistributedMetaStorageHistoryItem} created of
the related {@link Message} transfer wraps. */
+ static DistributedMetaStorageHistoryItem[]
of(DistributedMetaStorageHistoryItemMessage[] histMsgs) {
Review Comment:
Can we rename of() in both classes to be more explicit about the conversion
direction?
- DistributedMetaStorageHistoryItem#of → fromMessages
- DistributedMetaStorageHistoryItemMessage#of → toMessages
Yes, the names are slightly longer, but the intent is immediately clear at
call sites.
This also aligns with the existing pattern in Ignite
(`GridH2ValueMessageFactory#toMessage`, `StatisticsUtils#toMessage`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
