anton-vinogradov commented on code in PR #13421:
URL: https://github.com/apache/ignite/pull/13421#discussion_r3692166509
##########
modules/core/src/main/java/org/apache/ignite/internal/plugin/AbstractMarshallableMessageFactoryProvider.java:
##########
@@ -68,7 +68,7 @@ protected <T extends Message> void
register(IgniteMessageFactory factory, Class<
/** */
private static <T extends Message> void register(IgniteMessageFactory
factory, Class<T> cls, short id, Marshaller marsh) {
- MessageSerializer<T> serializer = requireGenerated(cls, "Serializer",
marsh);
+ MessageSerializer<T> serializer = require(loadGenerated(cls,
"Serializer", null), cls, "Serializer");
Review Comment:
Done in 3fdf446 — took the second option: `loadGenerated(cls, suffix, marsh,
required)`. The `require(...)` helper is gone, and the class and the suffix are
passed once.
##########
modules/core/src/main/java/org/apache/ignite/internal/plugin/AbstractMarshallableMessageFactoryProvider.java:
##########
@@ -79,44 +79,46 @@ private static <T extends Message> void
register(IgniteMessageFactory factory, C
if (NonMarshallableMessage.class.isAssignableFrom(cls))
marshaller = null;
else if (MarshallableMessage.class.isAssignableFrom(cls))
- marshaller = requireGenerated(cls, "Marshaller", marsh);
+ marshaller = require(loadGenerated(cls, "Marshaller", marsh), cls,
"Marshaller");
Review Comment:
Done in 3fdf446 — took the second option: `loadGenerated(cls, suffix, marsh,
required)`. The `require(...)` helper is gone, and the class and the suffix are
passed once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
