shishkovilja commented on code in PR #13423:
URL: https://github.com/apache/ignite/pull/13423#discussion_r3699817210
##########
modules/core/src/test/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSetSerializationTest.java:
##########
@@ -115,7 +114,7 @@ public static boolean deepEquals(SecurityPermissionSet lhs,
SecurityPermissionSe
return lhs != null
&& rhs != null
&& lhs.defaultAllowAll() == rhs.defaultAllowAll()
- && (F.isEmpty(rhs.systemPermissions()) &&
F.isEmpty(rhs.systemPermissions())
+ && (F.isEmpty(rhs.systemPermissions()) &&
F.isEmpty(lhs.systemPermissions())
Review Comment:
Good catch too, but I've removed deep copy in #13424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
