vldpyatkov commented on code in PR #13366:
URL: https://github.com/apache/ignite/pull/13366#discussion_r3713742418
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgnitePlanner.java:
##########
@@ -423,6 +423,15 @@ public String dump() {
return w.toString();
}
+ /** Returns whether the SELECT changes row cardinality using aggregation.
*/
+ @SuppressWarnings("deprecation")
+ public boolean isAggregate(SqlSelect select) {
+ SqlValidator validator = validator();
+
+ return validator.isAggregate(select)
+ || (select.getOrderList() != null &&
validator.isAggregate(select.getOrderList()));
Review Comment:
This part is required to find an aggregate in the ORDER BY list:
```
SELECT 1
FROM Person
ORDER BY COUNT(*)
FOR UPDATE;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
