anton-vinogradov commented on PR #13428: URL: https://github.com/apache/ignite/pull/13428#issuecomment-5181685509
Done, thanks — the line is gone. I did not add the two new classes in its place, and I want to say why, in case you meant that too. The list pre-registers names for classes that are marshalled *by name*. A message with a generated serializer travels by its direct type id, so its class name never reaches the wire. None of the messages written since the serializer migration are in the file: | class | in `classnames.properties` | |---|---| | `ErrorMessage` | no | | `GridTopicMessage` | no | | `CompressedMessage` | no | | `QueryEntityMessage` | no | | `IgniteFeatureSet` | no | | `RollingUpgradeClusterData` | no | The old entry looks like a leftover from the time `GridEventStorageMessage` was marshalled as an object. Its neighbour `GridJobExecuteRequest` is there for the same historical reason, and there are probably more — worth a sweep in a separate ticket, but I did not want to widen this PR. Happy to add both names if you think they are needed for a case I am missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
