tkalkirill commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3718526784
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractNode.java:
##########
@@ -37,6 +37,9 @@
* Abstract node of execution tree.
*/
public abstract class AbstractNode<Row> implements Node<Row> {
+ /** Special value to highlight that all rows were received and we do not
expect more. */
+ static final int NOT_WAITING = -1;
Review Comment:
Here are implementations that contain exactly the same constant:
org.apache.ignite.internal.processors.query.calcite.exec.rel.MergeJoinNode#NOT_WAITING
org.apache.ignite.internal.processors.query.calcite.exec.rel.AbstractRightMaterializedJoinNode#NOT_WAITING
Of course, you don't have to consolidate this or modify the existing classes
right now.
However, adding a shared constant for all subclasses isn't the right
approach either; it would be better to follow the existing pattern—that is,
adding a specific constant to each implementation:
org.apache.ignite.internal.processors.query.calcite.exec.rel.LimitNode#NOT_WAITING
org.apache.ignite.internal.processors.query.calcite.exec.rel.SortNode#NOT_WAITING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
