tkalkirill commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3720519728
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/SortNode.java:
##########
@@ -58,21 +57,21 @@ public class SortNode<Row> extends MemoryTrackingNode<Row>
implements SingleNode
public SortNode(
ExecutionContext<Row> ctx, RelDataType rowType,
Comparator<Row> comp,
- @Nullable Supplier<Integer> offset,
- @Nullable Supplier<Integer> fetch
+ long offset,
+ long fetch
Review Comment:
Use the declared default constants consistently throughout this constructor.
Replace the literal `-1` in the `fetch` parameter documentation with `{@link
#FETCH_DEFAULT}` and update the assertion accordingly:
```
assert fetch == FETCH_DEFAULT || fetch > 0 : "Unexpected fetch = " + fetch;
```
The delegating constructor should also pass `OFFSET_DEFAULT` and
`FETCH_DEFAULT` instead of the literal `0` and `-1` values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
