zstan commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3735945786
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java:
##########
@@ -86,13 +86,17 @@ private static List<List<Object>> numericsToRound() {
lst.add(F.asList("DECIMAL(20,1)", new
BigDecimal("-9223372036854775808.4"), "BIGINT", -9223372036854775808L));
lst.add(F.asList("DECIMAL(20,1)", new
BigDecimal("-9223372036854775808.5"), "BIGINT", overflowErr));
+ lst.add(F.asList("DECIMAL(20,1)", new
BigDecimal("-9223372036854775809.5"), "BIGINT", overflowErr));
Review Comment:
redundant this and all such below, because -9223372036854775808.5 already
checked
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/LimitOffsetIntegrationTest.java:
##########
@@ -54,7 +54,8 @@ public class LimitOffsetIntegrationTest extends
AbstractBasicIntegrationTransact
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
- // Override method to keep caches after tests.
+ // Keep caches between tests but do not leak an active transaction
into the next test.
+ clearTransaction();
Review Comment:
I wonder, why we need such code just here ? If this is some kind of problem
- fill an issue and revert this code. IntegrationTestSuite passed correctly for
me without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
