Vladsz83 commented on code in PR #13454:
URL: https://github.com/apache/ignite/pull/13454#discussion_r3750470687
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerRequest.java:
##########
@@ -47,10 +49,10 @@ public class DataStreamerRequest implements
DeferredUnmarshalMessage, CacheIdAwa
@Order(2)
String cacheName;
- /** */
- // TODO: Refactor bytes serialization - IGNITE-27977
+ /** Cache updater, {@code null} for the one the node ships with. */
Review Comment:
`the one the node ships with` -> `for the default`?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImpl.java:
##########
@@ -146,17 +146,14 @@ public class DataStreamerImpl<K, V> implements
IgniteDataStreamer<K, V>, Delayed
*/
private final Map<Long, ThreadBuffer> threadBufMap = new
ConcurrentHashMap<>();
- /** Isolated receiver. */
- private static final StreamReceiver ISOLATED_UPDATER = new
IsolatedUpdater();
+ /** Isolated receiver. Ships with the node, so it is never sent with a
request. */
Review Comment:
` Default Isolated receiver.`?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerRequest.java:
##########
@@ -25,15 +25,17 @@
import
org.apache.ignite.internal.managers.deployment.GridDeploymentInfoMessage;
import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
import org.apache.ignite.internal.processors.cache.GridCacheUtils;
+import org.apache.ignite.internal.util.tostring.GridToStringExclude;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.lang.IgniteUuid;
import org.apache.ignite.plugin.extensions.communication.CacheIdAware;
+import org.apache.ignite.stream.StreamReceiver;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import static org.apache.ignite.internal.GridTopic.TOPIC_DATASTREAM;
-/** */
+/** Batch of streamed entries. The updater is unmarshalled by the consumer,
which has the deployment class loader. */
Review Comment:
Let's not say how it is unmarshalled here.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImpl.java:
##########
@@ -655,7 +660,7 @@ public IgniteFuture<?> addDataInternal(Collection<? extends
DataStreamerEntry> e
lock(false);
- if (rcvr instanceof IsolatedUpdater &&
inconsistencyWarned.compareAndSet(false, true))
+ if (rcvrMsg == null && inconsistencyWarned.compareAndSet(false, true))
Review Comment:
Let's put a comment here too saying that `null` is ISOLATED_UPDATER
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
