vldpyatkov commented on code in PR #13366:
URL: https://github.com/apache/ignite/pull/13366#discussion_r3757180964
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/AbstractBasicIntegrationTest.java:
##########
@@ -269,20 +271,34 @@ protected List<List<?>> sqlAsRoot(IgniteEx ignite, String
sql) throws Exception
/** */
protected List<List<?>> sql(IgniteEx ignite, String sql, Object... params)
{
- // {@code sql} can contain more than one query.
- List<FieldsQueryCursor<List<?>>> allCurs =
queryProcessor(ignite).query(queryContext(), "PUBLIC", sql, params);
+ Transaction tx = ignite.transactions().tx();
+ QueryContext ctx = tx == null
+ ? queryContext()
+ : QueryContext.of(queryContext(), ((TransactionProxyImpl<?,
?>)tx).tx().xidVersion());
- if (allCurs.size() > 1) {
- log.warning("The query statement '" + sql + "' contains " +
allCurs.size() + " actual queries. " +
- "All the cursors are fetched, but only the last result is
returned.");
- }
+ if (tx != null)
Review Comment:
Because this class did not work with transactions. If this class could use a
public API, this call does automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
