nizhikov commented on code in PR #13461:
URL: https://github.com/apache/ignite/pull/13461#discussion_r3758920805
##########
modules/core/src/test/java/org/apache/ignite/internal/codegen/MessageProcessorTest.java:
##########
@@ -683,6 +685,57 @@ public void testNonMarshallableSelfMarshallingFailed() {
"or SelfMarshallingMessage, nor declare @Marshalled fields");
}
+ /** Test that {@code @Marshalled} annotation on {@link Message} field will
fail generation. */
+ @Test
+ public void testMarshalledOnMessageFieldFailGeneration() {
+ List<String> cases = Arrays.asList(
+ "MarshalledOnMessage.java",
+ "MarshalledOnMessageCollection.java",
+ "MarshalledOnMessageCollection2.java",
+ "MarshalledOnMessageCollection3.java",
+ "MarshalledOnMessageMap.java",
+ "MarshalledOnMessageMap2.java",
+ "MarshalledOnMessageMap3.java",
+ "MarshalledOnMessageArray.java",
+ "MarshalledOnMessageCollectionArray.java",
+ "MarshalledOnMessageSet.java",
+ "MarshalledOnMessageList.java",
+ "MarshalledOnMessageList2.java"
+ );
+
+ for (String file : cases) {
+ Compilation compilation = compile("TestMessage.java", file);
+
+ assertThat(compilation).failed();
+ assertThat(compilation).hadErrorContaining("Message must be
written by dedicated message serializers");
+ }
+ }
+
+ /** Test that {@code @Marshalled} annotation on raw {@link Collection}
fail generation. */
+ @Test
+ public void testRawCollectionFailGeneration() {
+ List<String> cases = Arrays.asList(
+ "TestRawListMessage.java",
+ "TestRawCollectionMessage.java"
+ );
+
+ for (String file : cases) {
+ Compilation compilation = compile("TestMessage.java", file);
Review Comment:
yes, it used in test classes as dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]