anton-vinogradov commented on code in PR #13462:
URL: https://github.com/apache/ignite/pull/13462#discussion_r3769547759


##########
modules/codegen/src/main/java/org/apache/ignite/internal/JdkMarshalled.java:
##########
@@ -14,25 +14,22 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package org.apache.ignite.internal;
 
-import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
-import org.apache.ignite.internal.binary.BinaryMarshaller;
-import org.apache.ignite.plugin.extensions.communication.Message;
-
-import static java.lang.annotation.ElementType.TYPE;
-import static java.lang.annotation.RetentionPolicy.RUNTIME;
 
 /**
- * In case message CAN contain user provided classes it must be marshalled 
with the {@link BinaryMarshaller}.
- * {@link BinaryMarshaller} is able to process user classes using schema 
tansfering protocol through Discovery.
- * Mark {@link Message} class with annotation to serialize it with {@link 
BinaryMarshaller}.
+ * Marshals the message with the JDK marshaller of the local node, whatever 
the transport speaks. Put it on a message
+ * that travels both transports: a {@link Marshalled} field caches its wire 
form, and only the JDK marshaller is read
+ * by both. It also asks no cluster-wide type registration, which never 
completes on a discovery thread.
+ *
+ * @see Marshalled
  */
-@Documented
-@Target(value = TYPE)
-@Retention(RUNTIME)
-public @interface UseBinaryMarshaller {

Review Comment:
   Now Discovery uses jdk, Communication - binary, with some exceptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to