shishkovilja commented on code in PR #13462:
URL: https://github.com/apache/ignite/pull/13462#discussion_r3776442412
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/binary/BinaryMetadataVersionInfo.java:
##########
@@ -29,7 +29,8 @@
* The version refers solely to the internal protocol for updating
BinaryMetadata and is unknown externally.
* It can be updated dynamically from different nodes and threads on the same
node.
*/
-@UseBinaryMarshaller
+// Travels both transports: by discovery in the data bag, by communication in
the MetadataResponseMessage.
Review Comment:
Comment should be placed into the Javadoc.
##########
modules/core/src/main/java/org/apache/ignite/internal/plugin/AbstractMessageFactoryProvider.java:
##########
@@ -87,28 +58,27 @@ private static <T extends Message> void
register(IgniteMessageFactory factory, C
boolean required = MarshallableMessage.class.isAssignableFrom(cls)
|| SelfMarshallingMessage.class.isAssignableFrom(cls);
- marshaller = loadGenerated(cls, "Marshaller", marsh, required);
+ marshaller = loadGenerated(cls, "Marshaller", required);
}
// Deployers are generated for GridCacheMessage subclasses only, so
the class lookup is skipped for the rest;
// a DeployableMessage left without a deployer is then rejected at
registration.
GridCacheMessageDeployer<?> deployer =
GridCacheMessage.class.isAssignableFrom(cls)
- ? loadGenerated(cls, "Deployer", null, false)
+ ? loadGenerated(cls, "Deployer", false)
: null;
factory.register(id, serializer, marshaller, deployer);
}
/**
- * Instantiates the generated companion class {@code
<message>Serializer/Marshaller/Deployer}. Only the marshaller
- * companion ever takes a {@code Marshaller}, and only when the message
has fields to marshal with one, so
- * {@code marsh} is {@code null} for the other two. Constructor lookups,
including missing companions, are cached
- * per message class in {@link #COMPANIONS}.
+ * Instantiates the generated companion class {@code
<message>Serializer/Marshaller/Deployer}. Companions are
+ * stateless: the marshaller, when one is needed, is passed per call by
the transport. Constructor lookups,
+ * including missing companions, are cached per message class in {@link
#COMPANIONS}.
*
* @return the companion, or {@code null} when it is not generated and
{@code required} is {@code false}.
*/
@SuppressWarnings("unchecked")
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
