Copilot commented on code in PR #13374:
URL: https://github.com/apache/ignite/pull/13374#discussion_r3819204229


##########
docs/_docs/sql-reference/window-functions.adoc:
##########
@@ -0,0 +1,163 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+= Window Functions
+
+Window functions calculate a value for each row returned by a query. The value 
is calculated over a set of rows related
+to the current row. This set of rows is called a window.
+
+A window function is identified by the `OVER` clause. The `OVER` clause 
defines how rows are partitioned, ordered, and
+framed for the function. Unlike regular aggregate functions, aggregate window 
functions do not collapse rows into a
+single grouped result.
+
+[NOTE]
+====
+Window functions are supported by the Calcite-based SQL engine.
+====
+
+== Supported Window Functions
+
+Ignite supports aggregate, ranking, and value functions with the `OVER` clause.
+
+[cols="1,3",opts="stretch,header"]
+|===
+|Type |Functions
+
+|Aggregate
+|`AVG`, `COUNT`, `MAX`, `MIN`, `SUM`

Review Comment:
   The "Supported Window Functions" table lists only `AVG`, `COUNT`, `MAX`, 
`MIN`, `SUM` as aggregate window functions, but later the page states that 
aggregate functions become window functions when used with `OVER`, and Ignite 
supports additional aggregates (e.g., `BIT_AND`, `BIT_OR`, `BIT_XOR`, etc.). 
This table entry is misleading/incomplete—either clarify that any supported 
aggregate can be used with `OVER`, or expand the list accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to