zstan commented on code in PR #13535:
URL: https://github.com/apache/ignite/pull/13535#discussion_r3892390936
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ConverterUtils.java:
##########
@@ -495,9 +495,9 @@ static List<Expression> convertAssignableTypes(Class<?>[]
targetTypes,
* Handles decimal type specifically with explicit type conversion.
*/
private static Expression convertAssignableType(Expression argument, Type
targetType) {
- if (targetType != BigDecimal.class)
+ if (targetType != BigDecimal.class ||
!Types.needTypeCast(argument.getType(), targetType))
Review Comment:
plz explain why do we need this branch ? '||
!Types.needTypeCast(argument.getType(), targetType)'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
