alex-plekhanov commented on code in PR #13517:
URL: https://github.com/apache/ignite/pull/13517#discussion_r3931586730


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/RunningQueryManager.java:
##########
@@ -231,6 +239,13 @@ public RunningQueryManager(GridKernalContext ctx) {
 
         canceledQrsCnt = userMetrics.longMetric("canceled", "Number of 
canceled queries that have been started " +
             "on this node. This metric number included in the general 'failed' 
metric.");
+
+        resultSetSizeHistogram = 
userMetrics.histogram("resultSetSizeHistogram",
+            new long[] {0, 1, 10, 100, 1_000, 10_000, 100_000, 1_000_000},

Review Comment:
   Fetching more than million entries for sql query it's not normal even if 
cluster contains billions (I think it's even not ok to fetch more than 1000 
entries).
   All fetches with more than million entries go to last bucket, so they will 
not be missed.
   Buckets are tunable, if someone think that it's ok to fetch million entries 
but not ok to fetch billion entries, it can be configured.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to