chesnokoff commented on code in PR #13558:
URL: https://github.com/apache/ignite/pull/13558#discussion_r3949746719
##########
.github/workflows/check-protected-classes.yml:
##########
@@ -53,13 +53,17 @@ jobs:
// Reproduce `git diff --no-renames --diff-filter=ADM`: a rename
is a delete(old)+add(new) pair.
// A protected class carries the @Order annotation; an added file
is defined by the head revision,
- // a deleted/modified one by the base.
+ // a deleted one by the base, and a modified one must be checked
in both revisions.
const revisions = [];
for (const f of files) {
if (f.status === 'added' || f.status === 'copied')
revisions.push([f.filename, headSha]);
- else if (f.status === 'removed' || f.status === 'modified' ||
f.status === 'changed')
+ else if (f.status === 'removed')
revisions.push([f.filename, baseSha]);
+ else if (f.status === 'modified' || f.status === 'changed') {
+ revisions.push([f.filename, baseSha]);
+ revisions.push([f.filename, headSha]);
+ }
Review Comment:
Check protected class before and after change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
