wernerdv commented on code in PR #13554:
URL: https://github.com/apache/ignite/pull/13554#discussion_r4004808149
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java:
##########
@@ -132,8 +133,25 @@ public void addRow(CacheDataRow row, IoStatisticsHolder
statHolder) throws Ignit
* @param statHolder Statistics holder to track IO operations.
* @throws IgniteCheckedException If failed.
*/
- public void addRows(Collection<? extends CacheDataRow> rows,
- IoStatisticsHolder statHolder) throws IgniteCheckedException {
+ public void addRows(Collection<? extends CacheDataRow> rows,
IoStatisticsHolder statHolder) throws IgniteCheckedException {
Review Comment:
Two points correct, one not.
(1) Rebalance-only: correct — regular puts use addRow (per-put reserve),
both paths covered.
(2) Per-row loop == reserve for the largest: correct — a single reserve for
the max row is equivalent.
(3) "Other rows go through writeSinglePage" — actually the batch path uses
insertDataRows, whose per-page protection now comes from the shared
takePageWithReserve re-reserve; the pre-reserve bounds the empty-pages counter
up front.
Updated comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
