tkalkirill commented on code in PR #13569:
URL: https://github.com/apache/ignite/pull/13569#discussion_r4015344342
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/TypeUtils.java:
##########
@@ -83,6 +85,10 @@
/** */
public class TypeUtils {
+ /** Start of the Gregorian part of the calendar used by JDBC temporal
types. */
+ private static final long GREGORIAN_CUTOVER =
Review Comment:
By “JDBC types” I meant `java.sql.Date` and `Timestamp`, which are also used
for embedded SQL results. I’ve clarified the comments.
These types and Calcite use different calendars before October 15, 1582.
Without this conversion, a UDF returning `LocalDate.of(1500, 1, 2)` produces
1499-12-24 in a plain SELECT.
This is covered by `TypeUtilsTest` and
`UserDefinedFunctionsIntegrationTest.testJavaTimeFunctionResultsAsJdbcValues`;
no JDBC driver tests were changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
