Copilot commented on code in PR #13602:
URL: https://github.com/apache/ignite/pull/13602#discussion_r4059769283
##########
modules/calcite/pom.xml:
##########
@@ -253,6 +275,70 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
Review Comment:
`hamcrest-core:3.0` is not the Hamcrest 3 artifact used by this repository;
the core module declares `org.hamcrest:hamcrest` at the same version
(modules/core/pom.xml:241-242). Maven will fail to resolve this dependency, so
use the `hamcrest` artifact here.
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/UnstableTopologyIntegrationTest.java:
##########
@@ -144,8 +148,6 @@ private QueryEntity queryEntity() {
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
stopAllGrids(true);
Review Comment:
This removes the call to `AbstractBasicIntegrationTest.afterTest()`, which
performs the per-test query, memory, mailbox, partition-exchange, and
plan-cache cleanup. JUnit 5 now invokes this override through `runAfterTest()`,
so the inherited cleanup is skipped for every `UnstableTopologyIntegrationTest`
case; restore the superclass call (or invoke the base cleanup before stopping
the grids).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
