chesnokoff commented on code in PR #13623:
URL: https://github.com/apache/ignite/pull/13623#discussion_r4132640124
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -132,6 +132,8 @@ public static Collection<?> parameters() {
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
+ super.afterTest();
Review Comment:
PerformanceStatisticsThinClientTest#afterTest() doesn't call
super.afterTest(), so .prf files are not cleaned between tests. testCompute
reads records from the previous test and fails.
To reproduce, run `testCompute` alone. It fails without the patch and passes
with it
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -132,6 +132,8 @@ public static Collection<?> parameters() {
/** {@inheritDoc} */
@Override protected void afterTest() throws Exception {
+ super.afterTest();
Review Comment:
PerformanceStatisticsThinClientTest#afterTest doesn't call super.afterTest,
so .prf files are not cleaned between tests. testCompute reads records from the
previous test and fails.
To reproduce, run `testCompute` alone. It fails without the patch and passes
with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
