rezataroosheh opened a new pull request, #13683:
URL: https://github.com/apache/ignite/pull/13683
### What
A cache configuration with an empty cache group name (`setGroupName("")`) is
now rejected early with a clear error: `Cache group name must not be empty.`
The check is done in two places:
- When a cache is started dynamically (`createCache` from a server, a client
node, a thin client, or SQL).
- When a node starts with a static cache configuration; the check runs
locally before the node joins the cluster.
`null` is still allowed and means the cache is not part of a group.
### Why
An empty group name used to break the cluster:
- A node starting with such a static cache configuration caused a critical
failure (`SYSTEM_WORKER_TERMINATION`) on the healthy nodes that were already
running. With the default failure handler, those nodes stop.
- A dynamic `createCache` failed with a confusing "Failed to complete
exchange process" error instead of a clear validation message.
Now invalid configuration fails on the node that sent it, and the rest of
the cluster is unaffected.
### Tests
New `CacheGroupNameValidationTest` (added to `IgniteCacheTestSuite2`) checks
the dynamic start from a client node, the thin-client start, and the static
configuration. For each, it checks that the error message is clear, no critical
failures occur on any node, and the cluster can still create and use a valid
cache. The test fails without the fix.
### The Contribution Checklist
- [x] There is a single JIRA ticket related to the pull request.
- [x] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [x] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where
`XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers
list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot
- Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance
2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to
Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity
Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email [email protected] or ask anу advice
on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
