nizhikov commented on code in PR #13668:
URL: https://github.com/apache/ignite/pull/13668#discussion_r4247770495
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/odbc/OdbcConnectionContext.java:
##########
@@ -166,23 +164,8 @@ public OdbcConnectionContext(GridKernalContext ctx,
GridNioSession ses, GridSpin
if (ver.compareTo(VER_2_13_0) >= 0) {
qryEngine = reader.readString();
- if (qryEngine != null) {
- QueryEngineConfiguration[] cfgs =
ctx.config().getSqlConfiguration().getQueryEnginesConfiguration();
-
- boolean found = false;
-
- if (cfgs != null) {
- for (int i = 0; i < cfgs.length; i++) {
- if
(qryEngine.equalsIgnoreCase(((QueryEngineConfigurationEx)cfgs[i]).engineName()))
{
- found = true;
- break;
- }
- }
- }
-
- if (!found)
- throw new IgniteCheckedException("Not found configuration
for query engine: " + qryEngine);
- }
+ if (qryEngine != null &&
!ctx.query().queryEngineConfigured(qryEngine))
Review Comment:
Agreed, it is a pre-existing gap. An ODBC test needs the C++ driver and the
platforms build, so it is out of scope here. Both handshakes call the same
`queryEngineConfigured()`, which is covered by the JDBC tests on both node
layouts (Calcite-only and no engine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
