NSAmelchev commented on code in PR #13649:
URL: https://github.com/apache/ignite/pull/13649#discussion_r4256787775
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupContext.java:
##########
@@ -980,7 +980,7 @@ public boolean persistenceEnabled() {
* @return {@code True} if {@link DataRecord} should be loged in the WAL.
*/
public boolean logDataRecords() {
- return walEnabled() && (persistenceEnabled || cdcEnabled());
+ return walEnabled() && (persistenceEnabled || (cdcEnabled() &&
!ctx.wal(true).cdcForceDisabled()));
Review Comment:
F. Kept: getOrDefault is a volatile read without allocation and the assert
is off in production; a flag on the context would duplicate the property state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
